[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

feg-adhoc · 2024-12-13T20:56:47Z

No description provided.

tate11 · 2025-01-15T21:18:41Z

Thank you for your effort. Gives a date error
time data '' does not match format '%d/%m/%Y'

Garanti Bankası 0 1 comma dot comma " %d/%m/%Y Date simple_value Amount Label

[FIX] Mostly currency-related fixes [IMP] sample_statement_en test: add dates on description Co-authored-by: Marco Colombo <[email protected]> [UPD] Update account_statement_import_txt_xlsx.pot

Translated using Weblate (Italian) Currently translated at 64.3% (56 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/it/ Translated using Weblate (Italian) Currently translated at 73.5% (64 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/it/ Translated using Weblate (Italian) Currently translated at 98.8% (86 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/it/

Currently translated at 100.0% (87 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/it/

Currently translated at 100.0% (87 of 87 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_txt_xlsx/es_AR/ account_statement_import_txt_xlsx 14.0.1.0.1

[UPD] Update account_statement_import_txt_xlsx.pot [UPD] README.rst

Currently translated at 100.0% (87 of 87 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/it/

…r IN and OUT [IMP] account_statement_import_txt_xlsx: wizard: amount2_reverse boolean field, with tests

…credit_column

… to column numbers, and concatenation A new field 'File does not contain header line' is added in the Statement Sheet Mappings. If you set to True, then you can map the columns by indicating in each field of the 'Columns' section the column number in the file. We also allow to concatenate multiple columns in the file to a single column to a single field of the statement line. You have to indicate the names of the columns separated by comma.

…ot provided in the import file [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/

…ping account_statement_import_txt_xlsx 15.0.2.0.1

If there is a problem parsing the file we are not showing the error to the user, instead a generic message telling something is wrong with the type of file is shown, and we only showing the error if we are running unit tests. In this case we think is good to show the error to the user, this way they can check what is wrong and fix it in the sheet mapping. * We are only showing the title of the error as a HINT, we think that is a good start to undestand what needs to change in the sheet mapping. * The complete traceback error is shown in the log if we needed for more detail review from the technical teams.

Currently translated at 74.4% (73 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/it/

Currently translated at 98.9% (97 of 98 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/es/

- Depending on the installed set of modules, the company currency may be USD or EUR. If the second case, these tests will fail, so we make sure that the company currency is USD for our tests, doing the change by SQL, as there's a Python constraint that prevents it. Not needed in v17 due to: odoo/odoo#107113. account_statement_import_txt_xlsx 15.0.2.0.2 [UPD] Update account_statement_import_txt_xlsx.pot account_statement_import_txt_xlsx 15.0.2.0.3 [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_txt_xlsx Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_txt_xlsx/

Co-authored-by: zaoral

[IMP] add csv meta data management [FIX] exclude footer meta data [IMP] import separated credit/debit column file [FIX] make comptatible with new version of multi_step_wizard module & add migration file [FIX] all not provided value are handled in_parse_decimal method [REF] Remove unnecessary \n Renamed to account_statement_import_sheet_file Co-authored-by: zaoral

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/

Currently translated at 100.0% (99 of 99 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/it/

Currently translated at 100.0% (99 of 99 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/

Currently translated at 100.0% (104 of 104 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/it/

feg-adhoc · 2025-02-04T14:44:33Z

Hello @tate11 ! Thank you for your feedback. Could you please specify how the file you used for testing is structured and how the mapping is configured? I am unable to reproduce the error.

tate11 · 2025-02-04T16:16:09Z

Hello @tate11 ! Thank you for your feedback. Could you please specify how the file you used for testing is structured and how the mapping is configured? I am unable to reproduce the error.

In Turkey, the date is used as day/month/year. It gives an error while importing like this.

feg-adhoc · 2025-02-04T18:03:06Z

@tate11 You need to change the mapping configuration and set the timestamp format field to %d/%m/%Y, and it will work correctly.

tate11 · 2025-02-04T20:49:10Z

@tate11 You need to change the mapping configuration and set the timestamp format field to %d/%m/%Y, and it will work correctly.
#747 (comment)
I tried this when we opened the issue .I opened this issue on top of that.
If you want, I can put the sample bank CSV file here.

feg-adhoc · 2025-02-25T15:25:01Z

Hello @tate11 getting back to this… The tests you ran, were they done before the latest code changes? If so, it might be worth checking again with the updated version. Also, could you please share the sample bank CSV file? That would help me take a closer look.

tate11 · 2025-02-26T07:01:03Z

Hello @tate11 getting back to this… The tests you ran, were they done before the latest code changes? If so, it might be worth checking again with the updated version. Also, could you please share the sample bank CSV file? That would help me take a closer look.

Thank you very much I tested the latest status today and it works.
Screenshot 2025-02-26 at 09-58-11 BNK1 sample bank statement-01111.xls

matteotrubini · 2025-02-28T12:26:15Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+                else None
+            )
+
+            if currency != currency_code:


Suggested change

if currency != currency_code:

if currency.lower() != currency_code.lower():

Avoid skipping lines just because 'eur' != 'EUR'
Ref.: #764

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch 5 times, most recently from 74d9ad5 to 3145831 Compare December 23, 2024 14:35

rov-adhoc approved these changes Jan 9, 2025

View reviewed changes

primes2h and others added 23 commits February 4, 2025 08:44

[MIG] account_bank_statement_import_txt_xlsx: Migration to 14.0

65a13bb

[FIX] Mostly currency-related fixes [IMP] sample_statement_en test: add dates on description Co-authored-by: Marco Colombo <[email protected]> [UPD] Update account_statement_import_txt_xlsx.pot

Added translation using Weblate (Portuguese)

ae66ba3

[account_statement_import_txt_xlsx][imp] add migration scripts

b02f33d

Added translation using Weblate (Spanish (Argentina))

82364a4

[MIG] account_statement_import_txt_xlsx: Migration to 15.0

06a999a

[UPD] Update account_statement_import_txt_xlsx.pot [UPD] README.rst

[FIX] account_bank_statement_import_txt_xlsx: import sheet notes

fadd960

[IMP] account_statement_import_txt_xlsx: wizard: 2 amount columns, fo…

025350b

…r IN and OUT [IMP] account_statement_import_txt_xlsx: wizard: amount2_reverse boolean field, with tests

[IMP] account_statement_import_txt_xlsx: amount_debit_column, amount_…

8ab5e8f

…credit_column

[IMP] account_statement_import_txt_xlsx: add tests

610f7f1

[FIX] account_statement_import_txt_xlsx: Don't try to parse if no map…

56a2c6f

…ping account_statement_import_txt_xlsx 15.0.2.0.1

Added translation using Weblate (Spanish)

eedddde

[MIG] account_statement_import_txt_xlsx: Migration to 16.0

e3a9a4a

Co-authored-by: zaoral

mileo and others added 15 commits February 4, 2025 08:44

[REF][account_statement_import_sheet_file] Remove decimal

0e64b91

[BOT] post-merge updates

0b96a7a

[IMP] account_statement_import_sheet_file: pre-commit execution

448fd6e

[MIG] account_statement_import_sheet_file: Migration to 17.0

9d7806c

[UPD] Update account_statement_import_sheet_file.pot

c816084

[BOT] post-merge updates

e3f0a94

[IMP] account_statement_import_sheet_file: additional mapping controls

dc47a58

[UPD] Update account_statement_import_sheet_file.pot

0f2f9c3

[BOT] post-merge updates

da41218

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch 6 times, most recently from 96e41c7 to 00f7713 Compare February 4, 2025 14:41

[MIG] account_statement_import_sheet_file: Migration to 18.0

9d48f60

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch from 00f7713 to 9d48f60 Compare February 4, 2025 14:43

matteotrubini reviewed Feb 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

feg-adhoc commented Dec 13, 2024

tate11 commented Jan 15, 2025

feg-adhoc commented Feb 4, 2025

tate11 commented Feb 4, 2025

feg-adhoc commented Feb 4, 2025

tate11 commented Feb 4, 2025 •

edited

Loading

feg-adhoc commented Feb 25, 2025

tate11 commented Feb 26, 2025 •

edited

Loading

matteotrubini Feb 28, 2025

	if currency != currency_code:
	if currency.lower() != currency_code.lower():

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

Are you sure you want to change the base?

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

Conversation

feg-adhoc commented Dec 13, 2024

tate11 commented Jan 15, 2025

feg-adhoc commented Feb 4, 2025

tate11 commented Feb 4, 2025

feg-adhoc commented Feb 4, 2025

tate11 commented Feb 4, 2025 • edited Loading

feg-adhoc commented Feb 25, 2025

tate11 commented Feb 26, 2025 • edited Loading

matteotrubini Feb 28, 2025

Choose a reason for hiding this comment

tate11 commented Feb 4, 2025 •

edited

Loading

tate11 commented Feb 26, 2025 •

edited

Loading